Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file should be fine to delete again after partial deletion on some blobbers #406

Closed
cnlangzi opened this issue Mar 3, 2022 · 1 comment · Fixed by #427
Closed

file should be fine to delete again after partial deletion on some blobbers #406

cnlangzi opened this issue Mar 3, 2022 · 1 comment · Fixed by #427
Assignees
@cnlangzi
Labels
mainnet

Comments

@cnlangzi
Copy link
Contributor

cnlangzi commented Mar 3, 2022 •
edited
Loading

for now, it can't be deleted again if a file were deleted from some of blobbers in pervious transaction. Because it is tuck on

gosdk/zboxcore/sdk/common.go

Line 20 in 5dd9517

func getObjectTreeFromBlobber(ctx context.Context, allocationID, allocationTx string, remotefilepath string, blobber *blockchain.StorageNode) (fileref.RefEntity, error) {
. And delete request will be cancelled as failure.
file should be deleted from remain blobbers.
@cnlangzi
Copy link
Contributor Author

cnlangzi commented Mar 3, 2022 •
edited
Loading

cc @stewartie4 delete still fails after 204 status code is fixed on blobber. that is new bug for it.

  • it works if file was deleted on disk, but not deleted from db
  • it doesn't work if file was deleted from db even it still be left on disk.

@cnlangzi cnlangzi changed the title file should be ok to deleted again after partial deletion file should be fine to delete again after partial deletion on some blobbers Mar 3, 2022
@princeparmar princeparmar linked a pull request Mar 5, 2022 that will close this issue
partial delete support. #407
Closed
3 tasks
@princeparmar princeparmar mentioned this issue Mar 5, 2022
Closed
3 tasks
@cnlangzi cnlangzi mentioned this issue Mar 28, 2022
Closed
3 tasks
This was referenced Apr 8, 2022
Merged
Merged
@cnlangzi cnlangzi linked a pull request Apr 8, 2022 that will close this issue
Feat/partial delete suppport #427
Merged
3 tasks
@cnlangzi cnlangzi assigned cnlangzi and unassigned princeparmar Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnlangzi cnlangzi

Labels
mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/partial delete suppport 0chain/gosdk
partial delete support. 0chain/gosdk
2 participants
@cnlangzi @princeparmar