Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yahnis-elsts/plugin-update-checker from 4.8.1 to 4.13 #116

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

dkotter
Copy link
Contributor

@dkotter dkotter commented Sep 8, 2022

Description of the Change

The Plugin Update Checker library we use is also used on a few other 10up projects. Some of those are running different versions though, leading to conflicts (especially when using composer to manage all dependencies of a project). This PR updates this library to the latest version, which will also be done in other repos that are using this library.

Alternatively we could use something like mozart or PHP-Scoper to add a distinct namespace to this dependency. I'm not opposed to this necessarily but because we're seeing conflicts with other plugins that we fully control, I like the idea of just ensuring all of those projects are using the same version.

How to test the Change

  1. Pull these changes down
  2. Within the 10up-experience.php file, set the version number to something lower, like 1.8.0
  3. Go to the plugins section and ensure you see an update notice for 10up Experience (may need to click the Check for updates link; also ensure the plugin is active)
  4. Click on the View version X.X.X details link and ensure you see proper details
  5. Go to the WordPress Updates page and ensure you see 10up Experience there as well, with the icon
  6. Click on the View version X.X.X details link and ensure you see proper details
  7. If desired, click the update now link and ensure an update works (either from the plugins page or the main updates page). Note though that this will wipe out your version controlled 10up-experience directory, so proceed with caution

Changelog Entry

Changed - Upgrade the Plugin Update Checker library to 4.13

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter
Copy link
Contributor Author

dkotter commented Oct 10, 2022

@tlovett1 Just bringing this to your attention for review as I know this impacts a number of projects that are using this plugin in conjunction with things like Distributor or Classifai

@tlovett1 tlovett1 merged commit ff3a791 into develop Oct 10, 2022
@tlovett1 tlovett1 deleted the feature/update-plugin-updater branch October 10, 2022 14:55
@dkotter dkotter linked an issue Oct 10, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump version for plugin update checker dependency
3 participants