Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against WordPress 5.8 #70

Closed
2 of 5 tasks
jeffpaul opened this issue Jul 1, 2021 · 1 comment · Fixed by #71
Closed
2 of 5 tasks

Test against WordPress 5.8 #70

jeffpaul opened this issue Jul 1, 2021 · 1 comment · Fixed by #71
Assignees
@barneyjeffries
Labels
help wanted needs:documentation This requires documentation. type:good-first-issue Good for newcomers.
Milestone
1.4.0

Comments

@jeffpaul
Copy link
Member

jeffpaul commented Jul 1, 2021 •
edited
Loading

Is your enhancement related to a problem? Please describe.
Once WordPress 5.8 is released, we'll want to test Ads.txt Manager to see if any incompatibility issues arise.

Describe the solution you'd like

  • test Ads.txt Manager on WordPress 5.8
  • open issues for any incompatibilities noted in testing
  • resolve issues identified in testing
  • bump "tested up to" version
  • if code changes needed due to incompatibilities, ship a plugin release, otherwise use "Plugin asset/readme update" action to update "tested up to" version on .org repo

Designs
n/a

Describe alternatives you've considered
none

Additional context
Related: #52, #65.
@jeffpaul jeffpaul added type:good-first-issue Good for newcomers. needs:documentation This requires documentation. labels Jul 1, 2021
@jeffpaul jeffpaul added this to the 1.4.0 milestone Jul 1, 2021
@jeffpaul jeffpaul moved this to To Do in Open Source Practice Oct 13, 2021
@barneyjeffries
Copy link
Contributor

@jeffpaul I have tested this locally against WP 5.8 and all seems to functioning correctly. PR here for the version bump: #71

@jeffpaul jeffpaul linked a pull request Oct 19, 2021 that will close this issue
bumped 'tested up to' and tested badge version to 5.8 #71
Merged
6 tasks
Repository owner moved this from To Do to Merged in Open Source Practice Oct 19, 2021
@jeffpaul jeffpaul mentioned this issue Jan 14, 2022
Closed
5 tasks
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barneyjeffries barneyjeffries

Labels
help wanted needs:documentation This requires documentation. type:good-first-issue Good for newcomers.
Projects
Open Source Practice
Archived in project
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

bumped 'tested up to' and tested badge version to 5.8 10up/ads-txt
2 participants
@jeffpaul @barneyjeffries