Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Extra Refresh to Push Content In Gutenberg #141

Closed
dkotter opened this issue Jun 26, 2018 · 5 comments · Fixed by #1022 or #1114
Closed

Gutenberg: Extra Refresh to Push Content In Gutenberg #141

dkotter opened this issue Jun 26, 2018 · 5 comments · Fixed by #1022 or #1114
Assignees
Labels
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Jun 26, 2018

By default, we only allow published content to be Distributed. In the Classic Editor, when you publish an item, the page refreshes and then the admin menu item is added by Distributor, which then allows us to push that item to other connections.

In Gutenberg, there are no page refreshes, so if you publish an item, the item is published but the page doesn't refresh, so the custom menu item is never added. This means you have to manually refresh the page before you can push that item anywhere. Not a huge deal but also not the most intuitive approach. Not sure the best way around this but would be nice, if possible, to listen for the post publish event and then add the dropdown menu.

@tlovett1 tlovett1 added type:bug Something isn't working. low priority and removed low priority labels Jul 28, 2018
@helen helen changed the title Extra Refresh to Push Content In Gutenberg Gutenberg: Extra Refresh to Push Content In Gutenberg Oct 11, 2018
@helen
Copy link
Contributor

helen commented Dec 5, 2018

I think for the new editor we should probably explore using a side panel instead of the admin bar. Generally we probably need to explore other push UI besides/in addition to the admin bar because it's possible to have it off or not have enough space especially on smaller screens.

@jeffpaul jeffpaul added this to the 2.0.0 milestone Jun 6, 2019
@jeffpaul jeffpaul modified the milestones: 3.0.0, 2.2.0 Mar 3, 2020
@jeffpaul jeffpaul modified the milestones: 2.2.0, 1.7.0 Apr 6, 2021
@jeffpaul jeffpaul modified the milestones: 1.7.0, 1.6.5 Apr 27, 2021
@helen
Copy link
Contributor

helen commented Aug 31, 2021

This belongs in a more major 1.7-type of milestone, can call it good enough for a point release in #750 but want to get into this and remove a lot of that hover code for the next release.

@helen helen modified the milestones: 1.6.5, 1.7.0 Aug 31, 2021
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice May 6, 2022
@jeffpaul jeffpaul moved this to Incoming in Open Source Practice May 6, 2022
@peterwilsoncc
Copy link
Collaborator

@jeffpaul Do you recall why you added the help wanted tag on this? It looks like it's fixed by the merged PRs #750 and #790.

@dkotter
Copy link
Collaborator Author

dkotter commented Jun 16, 2022

@peterwilsoncc I can't speak to the tag but there is still an issue here. Those referenced PRs definitely make the integration of Distributor and the block editor nicer but the don't fully solve the issue I opened here.

To recap, by default we only allow published items to be distributed so the distribution menu isn't even loaded if an item is in a non-published state. When an item is published in the block editor, because this doesn't refresh the page the menu is never shown.

We do show this now (coming from those referenced PRs), which lets the user know they need to refresh themselves:
Distributor refresh message

But I think there's still opportunity here for improvement, whether we lazy load in the menu after publish, whether we load it in at the beginning and only show it after publish, some other approach?

Also, and I didn't test this but I wonder if we have the same issue in reverse, for an item that is published and then gets put back in draft. I believe the distribution menu is probably still active until the page refreshes, though I'd have to test to see if it allows you to still distribute that item or not.

@peterwilsoncc
Copy link
Collaborator

Thanks for clarifying Darin.

For 1.7.0 I think I will keep the existing PRs as the bug fix and aim to remove the refresh in either 2.0.0 or 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Status: Done
6 participants