We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Notice: Undefined offset: 0 in /plugins/distributor/includes/pull-ui.php:394
Notice: Undefined offset: 0 in /plugins/distributor/includes/pull-ui.php:394
There is no check if there are ANY available post types.
$connection_now->pull_post_types = \Distributor\Utils\available_pull_post_types( $connection_now, $connection_type ); $connection_now->pull_post_type = $connection_now->pull_post_types[0]['slug'];
https://github.com/10up/distributor/blob/1.4.1/includes/pull-ui.php#L394
Steps to Reproduce
Expected behavior No PHP Notice
The text was updated successfully, but these errors were encountered:
@grappler I'm milestoning this for our larger 2.0.0 release and will look to get it resolved then, thanks again for the feedback!
Sorry, something went wrong.
@grappler I'm no longer seeing this PHP notice. Are you still seeing it? If so, can you confirm your WordPress, Distributor, and PHP versions?
@jeffpaul You can force the issue by including add_filter( 'dt_available_pull_post_types', '__return_empty_array' );
add_filter( 'dt_available_pull_post_types', '__return_empty_array' );
@grappler Thanks for the additional information here. I've been able to reproduce this and have a fix in place in #703
dkotter
Successfully merging a pull request may close this issue.
Describe the bug
Notice: Undefined offset: 0 in /plugins/distributor/includes/pull-ui.php:394
There is no check if there are ANY available post types.
https://github.com/10up/distributor/blob/1.4.1/includes/pull-ui.php#L394
Steps to Reproduce
Expected behavior
No PHP Notice
The text was updated successfully, but these errors were encountered: