Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed post shows as distributable (for external connections) #437

Closed
adamsilverstein opened this issue Jul 25, 2019 · 3 comments · Fixed by #444
Closed

Distributed post shows as distributable (for external connections) #437

adamsilverstein opened this issue Jul 25, 2019 · 3 comments · Fixed by #444
Labels
type:bug Something isn't working.
Milestone

Comments

@adamsilverstein
Copy link

Describe the bug
After distributing a post, the post is greyed out in the distributor admin-bar menu and a 'view' link links to the distributed post. This works correctly for network install/connections, however for external connections the remote site is first greyed out after distributing, then on a refresh shows as if the post can be distributed (despite having already been distributed to the remote site):

In this screenshot 'New Test' is an external connection site I have already distributed the post to, note that it shows as if I can distribute to it still. One of the multisite asites shows the correct behavior with a 'view' link. I included the post meta data in the screenshot where you can see the post has been distributed to the external connection.

image

Possibly broke in the lazy load menu refactor.

Steps to Reproduce

  1. Publish a post and distribute it to an external connection.
  2. Refresh the editor
  3. Open the Distributor admin-bar menu, note that the external connection is available for distributing.

Expected behavior
After distributing a post to an external site, the external site should be greyed out and ideally a 'View' link should point to the distributed post.

Screenshots
I noticed that as soon as you interact with one of the other connections, the connection becomes disabled:

image

Environment information

  • Device: Macbook
  • OS: MacOs latest
  • Browser and version: Chrome Beta
  • Distributor version: develop
  • Theme and version: ?
  • Other installed plugin(s) and version(s): ?
@jeffpaul
Copy link
Member

@adamsilverstein as @avag-novembit noted in #443, these two issues may be related. If so, does #444 appear to similarly resolve this issue?

@adamsilverstein
Copy link
Author

@adamsilverstein as @avag-novembit noted in #443, these two issues may be related. If so, does #444 appear to similarly resolve this issue?

Quite possibly - I'll give this a test.

@adamsilverstein
Copy link
Author

Verified that #444 does resolve the issue reported here. I do wonder after testing this why we don't show the "View" link for external connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants