Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Still Assign Term to Linked Post #468

Closed
turtlepod opened this issue Oct 18, 2019 · 4 comments · Fixed by #1069
Closed

Can Still Assign Term to Linked Post #468

turtlepod opened this issue Oct 18, 2019 · 4 comments · Fixed by #1069
Assignees
Labels
help wanted type:bug Something isn't working.
Milestone

Comments

@turtlepod
Copy link
Member

Describe the bug

Still able to add term in linked post (using Gutenberg)

Steps to Reproduce

  1. Distribute a post to another site in network, e.g from Site A (original) to Site B
  2. Edit the post in Site B.
  3. Should not be able to edit the post/add term in edit screen (need to unlink first)
  4. However, we can do that by clicking the label of the term.

Expected behavior

Should not be able to do this.

Screenshots

Environment information

  • Device: ThinkPad13
  • OS: Win10pro
  • Browser and version: Chrome
  • Distributor version: 1.5.0
  • Theme and version: Custom
  • Other installed plugin(s) and version(s):

Additional context

@turtlepod turtlepod added the type:bug Something isn't working. label Oct 18, 2019
@jeffpaul
Copy link
Member

@turtlepod can you confirm the version of WordPress that this is appearing in?

@turtlepod
Copy link
Member Author

WP 5.2.2, no gutenberg

@peterwilsoncc
Copy link
Collaborator

I noticed this applies to tags too in the most recent version of WordPress, the tags can be added in the distributed copy of the post but not removed.

If the origin post is updated, the custom terms are subsequently removed.

terms

@kmgalanakis-sage
Copy link

@jeffpaul I noticed that @peterwilsoncc tried to deal with this issue in #1069. Even though his approach has side-effects. I'm pretty sure this cannot be done with just CSS. Are we interested in investing more time on @peterwilsoncc 's fix to implement a JS solution or are we good with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:bug Something isn't working.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants