Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select All button placement and style #577

Closed
dkotter opened this issue Apr 16, 2020 · 3 comments · Fixed by #589
Closed

Select All button placement and style #577

dkotter opened this issue Apr 16, 2020 · 3 comments · Fixed by #589
Labels
help wanted type:enhancement New feature or request.
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Apr 16, 2020

In #495, a Select All button and a None button were added to the Distributor drop-down menu. This makes it easy to select all connections to distribute to at once, rather then having to select these individually.

Right now these buttons show above the connection list but seems like maybe we would want to move these buttons below that list, maybe even right align instead of left align?

Also, we use the same style for both the Select All and None buttons. Thinking maybe the None button should take the secondary button style that WordPress has, or maybe even just a text link?

Here are some screenshots on how it currently looks:

Default with no connections currently selected:
Screen Shot 2020-04-13 at 8 48 53 AM

All connections selected:
Screen Shot 2020-04-13 at 8 49 00 AM

Some connections selected but not all:
Screen Shot 2020-04-13 at 8 49 11 AM

@dkotter dkotter added the type:enhancement New feature or request. label Apr 16, 2020
@jeffpaul jeffpaul added this to the 2.1.0 milestone Apr 16, 2020
@dkotter
Copy link
Collaborator Author

dkotter commented May 19, 2020

Just noting these button styles were slightly changed in #569, that was recently merged in. Changed the None button to the secondary button style.

Screen Shot 2020-05-19 at 8 51 44 AM

Screen Shot 2020-05-19 at 8 51 53 AM

Screen Shot 2020-05-19 at 8 52 01 AM

@helen
Copy link
Contributor

helen commented Jun 4, 2020

I'm digging in here, just commenting to document my thought process and see if there's anything I'm overlooking or approaching in a funny way:

  • I think "Select All" should indeed go underneath the list.
  • "Select None" should actually probably be "Clear" and a text button next to the "Selected connection" header on the right.
  • The disabled states (already distributed and selected) in the list of available connections are not really visually discernible, need to do something with that.

@helen
Copy link
Contributor

helen commented Jun 9, 2020

Opened a PR for this in #589, there are a few things outstanding in there that are nice-to-haves but not blockers.

@jeffpaul jeffpaul modified the milestones: 2.1.0, 1.6.0 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants