Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show count of selected connections in Push menu #592

Closed
1 task
jeffpaul opened this issue Jun 10, 2020 · 1 comment · Fixed by #1020
Closed
1 task

Show count of selected connections in Push menu #592

jeffpaul opened this issue Jun 10, 2020 · 1 comment · Fixed by #1020
Assignees
@roshniahuja
Labels
help wanted needs:code-review This requires code review. nice-to-have type:enhancement New feature or request.
Milestone
2.0.0

Comments

@jeffpaul
Copy link
Member

jeffpaul commented Jun 10, 2020 •
edited by roshniahuja
Loading

Is your enhancement related to a problem? Please describe.

As an offshoot from #589, there's an additional UI improvement we can make to the Push menu in the form of noting how many connections are selected for distribution.

Describe the solution you'd like

  • Show the number of selected connections - this needs i18n consideration in whatever string, easier to just put the count in parens rather than trying to pluralize

Designs

n/a

Describe alternatives you've considered

n/a

Additional context

n/a
@jeffpaul jeffpaul added type:enhancement New feature or request. help wanted labels Jun 10, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Jun 10, 2020
@joshuaabenazer joshuaabenazer self-assigned this Feb 3, 2023
@roshniahuja roshniahuja self-assigned this Feb 20, 2023
@roshniahuja roshniahuja added the needs:code-review This requires code review. label Feb 21, 2023
@roshniahuja
Copy link
Contributor

I have Generated PR for this task.
Please have a look and let me know if is there anything.

@roshniahuja roshniahuja mentioned this issue Feb 21, 2023
Merged
4 tasks
@jeffpaul jeffpaul linked a pull request Feb 23, 2023 that will close this issue
Added selected connection count #1020
Merged
4 tasks
@jeffpaul jeffpaul moved this from 🆕 New to 🏗 In progress in Distributor 2.0.0 Feb 28, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Distributor 2.0.0 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roshniahuja roshniahuja

Labels
help wanted needs:code-review This requires code review. nice-to-have type:enhancement New feature or request.
Projects
No open projects
Distributor 2.0.0
Status: ✅ Done
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Added selected connection count 10up/distributor
3 participants
@joshuaabenazer @jeffpaul @roshniahuja