Comparing string with number in BenchmarkGroup

[Ryuno-Ki]

Describe the bug
While adding DocStrings for type annotation, I encountered a possible bug in

eleventy/src/BenchmarkGroup.js

Line 109 in 82d83f5

if (totalForBenchmark.toFixed(0) > 0) {

Number.prototype.toFixed() is resulting a String. You are comparing it with a number.
This will likely cause JavaScript to apply a type conversion (cannot tell offset which gets converted how).
What are you trying to do here?

Expected behavior
Both parts of the comparison should have the same type.

Screenshots

Environment:

• Eleventy Version 9042341

Additional context
Work in Progress Pull Request

[tannerdolby]

To avoid JavaScript applying an automatic type conversion, would it be an option just to convert the result of Number.prototype.toFixed() to a number like parseInt(totalForBenchMark.toFixed(0)) within the condition of the if statement so the relational operator > can properly compare the two numbers?

[victornpb]

Number.toFixed() is mostly used for number formatting hence the return type String. So casting it back to number isn't ideal.
Since its being used as a conditional it should probably be changed to

if (Math.round(totalForBenchMark) > 0) { }
// or
if (totalForBenchMark >= 0.5) { }

[zachleat]

Shipping with 3.0.0-alpha.17