Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admins can view menu items for areas they don't have permission to #394

Closed
GUI opened this issue Jul 13, 2017 · 1 comment
Closed

Admins can view menu items for areas they don't have permission to #394

GUI opened this issue Jul 13, 2017 · 1 comment

Comments

@GUI
Copy link
Member

GUI commented Jul 13, 2017

If an admin belongs to a group that lacks publishing permissions, they still see the Configuration > Publish Changes menu item, which is obviously a bit confusing. They can't actually publish anything (the permissions are working properly from that perspective), but they can still get to the page, where they might think they should be able to do something. We should make sure the menu items in the admin show and hide based on what the admin actually has permissions to.

I think this was working at one point, so I think this might have been a regressing in the v0.14 release of API Umbrella (since there were some internal shifts in how the menu items get rendered, and I suspect we missed this).

@GUI
Copy link
Member Author

GUI commented Aug 10, 2018

This has been fixed for a while, just forgot to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant