Sync package-lock.json after engines revision #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Because otherwise there are uncommitted changes on main when running `npm install` in a fresh clone. Linting already existed for this, but was not being run in CircleCI.
jmdembe
approved these changes
Oct 29, 2021
Apparently it's needed (for testing that built components include all expected USWDS components) See also: npm prelint script
**Why**: CircleCI convenience image for Ruby includes older version of NPM predating lockfileVersion 2, and therefore complains about changes
aduth
commented
Oct 29, 2021
| @@ -8,8 +8,22 @@ executors: | |||
| BUNDLER_VERSION: 2.2.20 | |||
|
|
|||
| commands: | |||
| node-install: | |||
There was a problem hiding this comment.
Pulled from equivalent IdP configuration (18F/identity-idp#5227). Needed because by default, the CircleCI Ruby convenience image uses an older version, with an old NPM not capable of handling the NPM>=7 lockfileVersion: 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue introduced via: #266
Why: Because otherwise there are uncommitted changes on main when running
npm installin a fresh clone.Linting already existed for this, but was not being run in CircleCI.