Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumps of post-2015-manufactured carts fail MAC verification #116

Closed
mariomadproductions opened this issue Apr 10, 2022 · 6 comments
Closed

Comments

@mariomadproductions
Copy link

mariomadproductions commented Apr 10, 2022

E.g. Legend of Zelda, The - Majora's Mask 3D (Europe) (En,Fr,De,Es,It) passes verification, but Legend of Zelda, The - Tri Force Heroes (Europe) (En,Fr,De,Es,It) fails. The manufacturing date may not be that relevant, but it gives you an idea of which ROMs are affected at least. I checked a few pre-2015 carts and a few post-2015 carts.

Its possible this is a GodMode9 issue, and if so I'll close this issue and open on on its issue tracker, but I used GM9's verification function on one of the ROMs that fails in ctrtool, and it passed there, so I thought it made sense to open it here.

Thanks

@jakcron
Copy link
Collaborator

jakcron commented Apr 11, 2022

Turns out I misunderstood how the initial-data key is selected. I checked TriForce heros, and while CTRTool currently fails the InitialData MAC, it would seem to be my mistake.

I'll comment here when I update CTRTool.

@profi200
Copy link
Collaborator

Can confirm the MAC verification fail. This might or might not help since it's a little easier to read than most other implementations:

https://gist.github.com/profi200/3fa1ff70d5fe68457fc0eb0acd93a85d#file-gamecard-c-L430

@jakcron
Copy link
Collaborator

jakcron commented Apr 11, 2022

@mariomadproductions
Please try these builds of CTRTool and let me know if that fixes the issue:
ctrtool-win_x64.zip
ctrtool-win_x86.zip
ctrtool-ubuntu_x86_64.zip
ctrtool-macos_x86_64.zip
ctrtool-macos_arm64.zip

@mariomadproductions
Copy link
Author

That seems to have fixed it - I've tested it on a few that failed before and now they pass. Glad to see this wasn't a dumping error.

@jakcron jakcron closed this as completed Apr 11, 2022
@jakcron
Copy link
Collaborator

jakcron commented Apr 11, 2022

Thank you for testing this.

This is fix is included in the v1.0.4 release, which is available on the releases page.

@mariomadproductions
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants