Segfault when running makerom v0.18.2

[lephilousophe]

When running makerom in 64-bit Linux, a SIGSEGV happens in yaml_parser_append_tag_directive when checking if a directive already exists.
This is because the directive handle pointer pushed is invalid.
The root cause is that when running gcc with -std=c11, strdup is not defined on Linux.
When it is used in yaml_strdup, it is then implicitly defined as returning int which is 32-bit size on Linux (the generated assembly code truncates the strdup result using CDQE instruction.
Two solutions for this: either use -std=gnu11 which enables all GNU extensions or add -D_GNU_SOURCE to CFLAGS to make strdup defined (gnu11 makes this definition plus enables other extensions) in file makerom/deps/libyaml/makefile.

[jakcron]

Thank you for flagging. I’ll investigate.

[jakcron]

I decided to add -D_GNU_SOURCE to CFLAGS for the affected modules.

This is effective in MakeROM v0.18.3.

https://github.com/3DSGuy/Project_CTR/releases/tag/makerom-v0.18.3

[jakcron]

Thank you for filing this bug. I'll make sure to watch the warnings more carefully for other targets in future.