Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: package.json: Remove "type": "commonjs" #238

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Conversation

msabramo
Copy link
Contributor

@msabramo msabramo commented Aug 6, 2021

and let webpack auto-detect.

As suggested at webpack/webpack#12598 (comment)

Fixes: GH-237

@msabramo msabramo mentioned this pull request Aug 6, 2021
@franky47
Copy link
Member

franky47 commented Aug 6, 2021

Thanks, I'll try and release it as a beta so you can try it in your project.

@msabramo
Copy link
Contributor Author

msabramo commented Sep 7, 2021

Let me know if you want me to try anything out. I'm happy to test.

@franky47 franky47 merged commit 656f533 into 47ng:next Sep 7, 2021
franky47 added a commit that referenced this pull request Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

🎉 This PR is included in version 1.4.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import fails
2 participants