Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark framework packages as optional peer dependencies #697

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

franky47
Copy link
Member

@franky47 franky47 commented Oct 22, 2024

TIL: all package managers download and install optionalDependencies. To mark them as optional peer, we need to leverage peerDependenciesMeta.{packageName}.optional: true.

Closes #696.

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 9:24pm

Copy link

pkg-pr-new bot commented Oct 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/nuqs@697

commit: 31ee7a3

@franky47 franky47 marked this pull request as ready for review October 22, 2024 21:28
@franky47 franky47 merged commit df9e834 into next Oct 22, 2024
23 checks passed
@franky47 franky47 deleted the fix/696-pnpm-peer-dependencies branch October 22, 2024 21:29
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm add nuqs install both remix and next
1 participant