Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Encode invisible ASCII control characters #783

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

franky47
Copy link
Member

Closes #779.

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 3:24pm

@franky47 franky47 added this to the 🪵 Backlog milestone Nov 23, 2024
Copy link

pkg-pr-new bot commented Nov 23, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/nuqs@783

commit: f387eb7

@franky47 franky47 enabled auto-merge (squash) November 23, 2024 15:24
@franky47 franky47 merged commit c768757 into next Nov 23, 2024
24 checks passed
@franky47 franky47 deleted the fix/779-encode-hidden-characters branch November 23, 2024 15:25
Copy link

🎉 This PR is included in version 2.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@franky47 franky47 removed this from the 🚀 Shipping next milestone Nov 23, 2024
@franky47 franky47 mentioned this pull request Nov 23, 2024
@franky47 franky47 modified the milestone: 🚀 Shipping next Nov 26, 2024
chars.forEach(char => {
expect(encodeQueryValue(char)).toBe(encodeURIComponent(char))
})
})
test('Alphanumericals are passed through', () => {
const input = 'abcdefghijklmnopqrstuvwxyz0123456789'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lỉne

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New lines are being filtered out
2 participants