fix: Dynamic keys for useQueryStates #858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/nuqs/src/useQueryStates.test.ts:296
- The expectation for result.current[0].d should be consistent with other checks. It should be expect(result.current[0].d).toBeUndefined().
expect(result.current[0].d).toBeNull()
packages/nuqs/src/useQueryStates.ts:116
- Comparing the joined strings of keys and values is unconventional and error-prone. Consider comparing the lengths of the arrays instead.
Object.keys(queryRef.current).join('&') !== Object.values(resolvedUrlKeys).join('&')
yarinsa
approved these changes
Jan 14, 2025
franky47
force-pushed
the
fix/799-dynamic-keys
branch
from
c5f62b1 to
ff2570f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Closes #799.