feat: Shallow routing for everyone #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
franky47
commented
Dec 16, 2024
It's needed for frameworks that want to be reactive to any change in the search params, even coming from 1st/3rd party code calling the history API directly.
URL.canParse isn't available in Cypress, so we consider it unavailable in client code too, and replace it with a bespoke implementation that extracts search params from whatever can be fed to the history API.
franky47
force-pushed
the
feat/shallow-routing-for-everyone
branch
from
6e7195e to
acbdf28
Compare
|
🎉 This PR is included in version 2.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable shallow routing support in:
For some of these, patching the History API methods will be necessary to spy on external calls from first/third party code. This will be provided as an opt-in method exported from the adapters, to call in top-level client code.
Tasks
shallow: true | falsein hook optionsnuqs/adapters/react-router) -> Move to fix: Support moduleResolution: bundler #719