Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release helm chart failing due to invalid token #209

Merged
merged 7 commits into from
Jul 3, 2024
Merged

fix: release helm chart failing due to invalid token #209

merged 7 commits into from
Jul 3, 2024

Conversation

shivaccuknox
Copy link
Contributor

@shivaccuknox shivaccuknox commented Jul 2, 2024 •
edited
Loading

Description

The token used for pushing helm charts was no longer valid. Modified the token to be independent of owner.
Screenshot from 2024-07-02 11-48-42

Screenshot from 2024-07-02 11-49-19

Fixes # #202, #210

Does this PR introduce a breaking change?

No

Checklist

  • [*] PR title follows the <type>: <description> convention
  • [*] I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • [*] I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

@shivaccuknox shivaccuknox marked this pull request as ready for review July 2, 2024 06:31
@shivaccuknox shivaccuknox marked this pull request as draft July 2, 2024 07:37
@shivaccuknox shivaccuknox marked this pull request as ready for review July 3, 2024 09:02
VedRatan
VedRatan approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@VedRatan VedRatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VedRatan VedRatan merged commit 7f7a00e into main Jul 3, 2024
18 checks passed
@VedRatan VedRatan deleted the shiv/github-app branch July 3, 2024 09:26
@shivaccuknox shivaccuknox linked an issue Jul 3, 2024 that may be closed by this pull request
coco adapter: kyverno is unable to mutate deployments because of cluster role permissions #210
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VedRatan VedRatan VedRatan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coco adapter: kyverno is unable to mutate deployments because of cluster role permissions
2 participants
@shivaccuknox @VedRatan