-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to display line numbers that weren't executed #26
Conversation
It'll need a rebase and a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks
Thanks for the review. Seems that a coverage check is failing. Looks like it fails on parsing my new |
I get a YAML validation error on line 31 when I run it through a validator. Maybe some weird white space?
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ddeab80 |
Read the file name in the error a bit too quickly, was looking in the wrong file. There was a misplaced escape character on the failing line. |
Option name is: 'show_missing'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really awesome work! 💯
Just double-checking, did you run npm run package
after the last changes? (Would be sweet if we could automate this.. At least it's better than keeping node_modules under version control)
Yeah, should be all good. Ran it without any diff just now. |
I took a swing at #16, displaying lines that weren't executed (uncovered lines) in the markdown table.
Added an option
show_missing
(default=false) for a column inclusion.Although this doesn't include any fancy pants tracing of lines during branching
(e.g. misses on "jumps" that
coveragepy
outputs as:22 -> 45
)Anyhow, let me know what you think. Great package. Thanks.