Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm search #174

Merged
merged 46 commits into from
Mar 5, 2017
Merged

npm search #174

merged 46 commits into from
Mar 5, 2017

Conversation

45kb
Copy link
Member

@45kb 45kb commented Feb 22, 2017

not yet ready

ref: #7

CURRENT STATUS

Problems:

1 - npm.config.set('json', true) seems needed in order to output in json format and so we should add it but i don't know if this could break some other command and scenarios around the app. Must be tested.

2 - The search output is a stream so it's not readable inside the promise https://github.com/720kb/ndm/blob/search/lib/js/interface/top.js#L301

Atm on hold of https://github.com/720kb/ndm/issues/178

@45kb
Copy link
Member Author

45kb commented Mar 5, 2017

switched to web api search, closes #7

@45kb 45kb merged commit 2b4a24b into master Mar 5, 2017
@wouldgo wouldgo deleted the search branch March 5, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants