Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page.name is not correct for rdf resource #147

Closed
white-gecko opened this issue Dec 19, 2017 · 5 comments · Fixed by #154
Closed

page.name is not correct for rdf resource #147

white-gecko opened this issue Dec 19, 2017 · 5 comments · Fixed by #154
Assignees
Labels
Milestone

Comments

@white-gecko
Copy link
Member

if the config.baseurl is empty the page.name starts with a slash, even though, it should just be the file name.

@white-gecko white-gecko added this to the 3.0.1 milestone Dec 19, 2017
@Simaris
Copy link
Collaborator

Simaris commented Jan 21, 2018

the reason is that page.name is an alias for page.rdf.render_path (in our plugin).
We made specific rules for render_path in #94
page.name currently abides by these rules

@white-gecko
Copy link
Member Author

I think the page.name should be the IRI/URI in our case.

@Simaris
Copy link
Collaborator

Simaris commented Jan 26, 2018

That might be intrusive to jekylls rendering behaviour. page.name is a predefined variable for the actual name of the file (index.html, main.html etc.) and plays a role in determining where a page is rendered to.

@white-gecko
Copy link
Member Author

Do we know that or is this a guess? Can you find any documentation about that? If it is actually defining, where the page is rendered to, than why is it index.md for a file called index.md, which is rendered to index.html. I think this is actually for where the page is rendered from and that is in our case an RDF resource which is identified by an IRI.

@Simaris
Copy link
Collaborator

Simaris commented Apr 7, 2018

My guess is that we are not supposed to use page.name, since it is not listed in Jekyll variable doc nor in this chaet sheet.
We probably should make page.title viable instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants