ark-cli: Depend on Workspace Crates Instead of arklib
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillt
approved these changes
Apr 10, 2024
This commit removes `ark-cli` dependency on `arklib` and depends on other `ark-rust` crates from the workspace. This should be the last step of merging `ark-cli` into `ark-rust` cargo workspace. Next step is to archieve both `arklib` and `ark-cli`. Other changes: - disable benches for `ark-cli` - remove unused `ark-cli` unused crate dependencies Signed-off-by: Tarek <[email protected]>
tareknaser
force-pushed
the
cli_dependencies
branch
from
561e42c to
42382eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
ark-clidependency onarkliband depends on otherark-rustcrates from the workspace.This should be the last step of merging
ark-cliintoark-rustcargo workspace.Fixes #15
Next steps:
ark-rustarklibandark-cliOther changes:
ark-cliark-cliunused crate dependencies