Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplication of global static variable BLE_EVT_BUFFER #39

Closed
rgrover opened this issue Aug 11, 2015 · 3 comments
Closed

remove duplication of global static variable BLE_EVT_BUFFER #39

rgrover opened this issue Aug 11, 2015 · 3 comments

Comments

@rgrover
Copy link
Contributor

rgrover commented Aug 11, 2015

With #32, we duplicated the call to SOFTDEVICE_HANDLER_INIT(), which now results in two separate instances of BLE_EVT_BUFFER objects. This can be avoided.
@rgrover
Copy link
Contributor Author

rgrover commented Aug 11, 2015

notify @jpbrucker

@rgrover
Copy link
Contributor Author

rgrover commented Aug 11, 2015

@jpbrucker: could you please review this change?

@jpbrucker
Copy link
Contributor

Looks good to me. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgrover @jpbrucker