Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some sub-types and constants applicable to GapAdvertisingParams could be extracted to BLEProtocol.h #144

Open
rgrover opened this issue Dec 15, 2015 · 3 comments

Comments

@rgrover
Copy link
Contributor

rgrover commented Dec 15, 2015

AdvertisingType_t can encapsulated into a struct and possibly be moved.
we can create types for advertising interval and timeout.
constants defining min and max for the interval and timeout could be extracted.

@andresag01
Copy link

@rgrover: If we are thinking of moving the constants defining min and max for the interval and timeout perhaps we should also consider moving the constants in GapScanningParams. See https://github.com/ARMmbed/ble/blob/master/ble/GapScanningParams.h#L22.

@ciarmcom
Copy link
Member

ARM Internal Ref: IOTSFW-1421

@rgrover
Copy link
Contributor Author

rgrover commented Dec 15, 2015

@andresag01 yes, that's valid. Thanks for bringing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants