New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent use of uint_16_t and Handle_t #34

Closed

aleksanb opened this issue Feb 22, 2015 · 1 comment

aleksanb commented Feb 22, 2015

Hey.
getHandle returns a Handle_t, but updateCharacteristicValue expects an uint_16_t.

This was rather confusing, until i discovered that Handle_t was a typedef of uint_16_t.

May i suggest returning a uint_16_t from updateCharacteristicValue instead, as the discrepancy feels somewhat confusing?

Contributor

rgrover commented Feb 22, 2015

yup. This was on my todo list. Thanks for pointing this out. Fix should arrive shortly.

rgrover closed this as completed in

07ef7dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment