-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade of FactomineR breaks the tools gsc_high_dimentionnal_visualisation #649
Comments
For convenience, here is the code adapted to Rstudio (getting rid of optparse stuff)
|
I think I found it !! It seems that parameters of
I don't understand why there is |
yeah ! I saw the same this week end. In any case, I will completely refactor the code for PCA by this tool, because we were not using factomineR properly ! quantitative as well as qualitative factor mais be added since the beginning in the input data set and specified when the PCA function is called. From this, visualisation of results (based on ggplot2) is just a piece of cake with the PCA.plot function ! I did not have time to see, but I guess it should be the same for HCPC ! And yes, factor_cols <- rep("deepskyblue4", length(rownames(data))) is a genuine error !... but we don't care anymore since factomineR is managing this for us ! |
Current situation
The tool has the following dependencies and passes all tests
with upgrade
the #648 PR upgrade, the R environment is turned into 4.3.1 with the following conda packaging
I have adapted the code for testing in Rstudio, and could find that there is a problem with the
plot.PCA
wrapped function of factominer.Typically,
return errors of type
Help !
@bellenger-l I could detemine that the faulty parameter is
col.ind
but coud not figure out why. Ok, there is a problem of lenght mapping, but even if you manually force thefactor_cols
to have the length asked by R (1033), it is still poping up the same complaint !Could you look at this and help me to fix, @bellenger-l ?
I have also noted the existence of other possible parameter like
habillage
and col.hav or col.var, etc...last but not least, in this code there is something "odd":
ok for the transposition of the dataframe ! cells are observations and gene are the real variables.
But then, why are the number of colors of observations is determined by (for instance) line 328:
since at this (early) stage of the script, columns are still observations ????
By the way, as you see, factomineR was (very) recently upgraded !!
The text was updated successfully, but these errors were encountered: