Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept of a causationId / "commit sequence" might be useful? #22

Open
PeterStephenson opened this issue Oct 24, 2017 · 2 comments
Open

Comments

@PeterStephenson
Copy link

In the recent issue we found it really useful to see which events were saved in the same transaction as it showed that there was an issue cross thread. Without this information diagnosing the issue would have been very difficult. I can imagine situations where this is similar (especially where events can written out of order and can be triggered by multiple handlers)

Is it worth adding something like this? It doesn't need to be a wrapper or anything possibly just a guid indicating what was saved at the same time?

@DaveAurionix
Copy link

We added a correlation id to the event metadata, I don't know if you could do something similar? Correlation Id won't be unique to a commit, but you could literally add a CommitId.

@asosMikeGore
Copy link

Using the metadata for this is a good fit and doesn't require a change. It also means that you can then add additional items e.g. a causation id as well as correlation.

If this was added to the schema then we'd want the clients to master this, so they can use any identifier they need. A "transaction id" by itself (i.e. we master the id) likely isn't too helpful if you think about correlating this id across different activities across multiple services.

Is it worth us adding this in based on this, or just use the metadata? My preference right now is the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants