-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: allow subdomains of childOrigin #92
Comments
Thanks for logging this. I don't think supporting this securely is very straightforward since Penpal is limited by the underlying In the scenario you're describing, the parent would need to know the child's specific subdomain in order to securely connect to the child. I'll keep thinking about this. I'm open to ideas. |
Would there be any interest in implementing this by using the referrer URL and doing some manual parsing? |
I actually have an implementation on the workers branch that supports a regex or string for both If you want to try it out, give it spin! I can also publish a pre-release version to npm if that would help. |
@Aaronius kindly ping. Any progress? |
Hi @lpellegr. No progress since my last message. I do want to get the new version released this winter, but I can't promise anything. |
@Aaronius Thank you for the information! This library is absolutely fantastic—you’ve done an incredible job. I truly appreciate your efforts. Keep up the great work! I’m excited to try out the new version once it’s released. |
In #73, the ability to allow any child origin was added via
'*'
. We'd like to do the same thing, but with the restriction of only allowing subdomains of the original child origin as a safer alternative. We can sometimes redirect to a subdomain for certain customer configurations.Proposed change: if the configured
childOrigin
domain begins with.
, treat subdomains as equivalent.The text was updated successfully, but these errors were encountered: