Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow subdomains of childOrigin #92

Open
scottanderson42 opened this issue Nov 14, 2023 · 6 comments
Open

Feature request: allow subdomains of childOrigin #92

scottanderson42 opened this issue Nov 14, 2023 · 6 comments

Comments

@scottanderson42
Copy link

In #73, the ability to allow any child origin was added via '*'. We'd like to do the same thing, but with the restriction of only allowing subdomains of the original child origin as a safer alternative. We can sometimes redirect to a subdomain for certain customer configurations.

Proposed change: if the configured childOrigin domain begins with ., treat subdomains as equivalent.

@Aaronius
Copy link
Owner

Thanks for logging this. I don't think supporting this securely is very straightforward since Penpal is limited by the underlying postMessage browser API. When using postMessage, the target origin needs to be specified as * or a specific origin.

In the scenario you're describing, the parent would need to know the child's specific subdomain in order to securely connect to the child. I'll keep thinking about this. I'm open to ideas.

@nqustein
Copy link

Would there be any interest in implementing this by using the referrer URL and doing some manual parsing?

@Aaronius
Copy link
Owner

I actually have an implementation on the workers branch that supports a regex or string for both parentOrigin (when connecting from child to parent) and childOrigin (when connecting from parent to a child). That branch also includes support for workers (instead of just iframes) and transferables. It's not quite ready to release though. I think the main thing remaining is getting the types straightened out, particularly for the transferables support.

If you want to try it out, give it spin! I can also publish a pre-release version to npm if that would help.

@lpellegr
Copy link
Contributor

@Aaronius kindly ping. Any progress?

@Aaronius
Copy link
Owner

Hi @lpellegr. No progress since my last message. I do want to get the new version released this winter, but I can't promise anything.

@lpellegr
Copy link
Contributor

@Aaronius Thank you for the information!

This library is absolutely fantastic—you’ve done an incredible job. I truly appreciate your efforts. Keep up the great work! I’m excited to try out the new version once it’s released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants