commits and notes for v3.1.6 release #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian Amann <[email protected]>
Signed-off-by: Julian Amann <[email protected]>
Signed-off-by: Chris Kulla <[email protected]>
…dation#255) The issue with the warning of halfLimits.h being deprecated is that it is very tempting to simply remove the include of halfLimits.h in favor of simply half.h. However this change does depends on the version of Imath used, and halfLimits.h should be kept for compatibility with older version. Simply do not warn if short.h is already included. Signed-off-by: Jules Maselbas <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
* Hide x86 intrinsics from Cuda compilation (half.h) that is a hard error when compiling for Cuda. * Avoid warnings about host/device decorations for defaulted destructors for Color3, Color4, Euler, Quat, and Shear classes -- if you define the destructor as `= default`, you shouldn't also add the IMATH_HOSTDEVICE decorator. Signed-off-by: Larry Gritz <[email protected]>
…ademySoftwareFoundation#261) If extractSHRT failes in computeRSMatrix, it's an error, so throw. If extractSHRT fails in testMatrix in testExtractSHRT.cpp, it's fatal. The test was present for testMatrix(M33f) but missing for testMatrix(M44f). This lead to an uninitialized memory refererence since the failure leaves the arguments uninitialized. Signed-off-by: Cary Phillips <[email protected]>
* Fix example code so it compiles as is * Add missing includes * Make intro example actually do something sensible, and move to intro.cpp * Add building the example code to the CI Signed-off-by: Cary Phillips <[email protected]> * Add missing add_test Signed-off-by: Cary Phillips <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
…cademySoftwareFoundation#263) Signed-off-by: Cary Phillips <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
* Fix gcc compiler warning in testFun.cpp PR AcademySoftwareFoundation#250 changed the %lx to %llx to suppress an MSVC warning, but it introduced a gcc warning, where uint64_t is long, not long long. Better to leave it as %lx and just cast to long. It's only a printf anyway. Signed-off-by: Cary Phillips <[email protected]> * cast to unsigned long long for %llx Signed-off-by: Cary Phillips <[email protected]> * In printf, bit_cast to uint<n>_t and use PRIx<n> This shoudl properly avoid warnings on all platforms. Signed-off-by: Cary Phillips <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
lgritz
approved these changes
Oct 31, 2022
Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch release with miscellaneous bug/doc/build fixes.
[#269] fix memory leak in V3fArrayFromBuffer
[#268] Add
<cstdint>forint64_t[#263] Initialize x in
testRoots.cpp:solve()to suppress compiler warning[#262] Fix gcc compiler warning in
testFun.cpp[#261] Test return value of
extractSHRTto avoid uninitialized reference[#260] Fix example code so it compiles as is
[#259] Cuda safety in several headers
[#256] Fix markdown and typos in
README.md[#255] Do not warn if
half.hhas already being included[#250] Fix compiler warnings on windows
[#249] Remove irrelevant cvs ignore files
[#248] Update sphinx version