Fix system python and added yum wrapper #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aloys Baillet <[email protected]>
aloysbaillet
force-pushed
the
fix-system-python
branch
from
640afd8 to
c08910a
Compare
bcipriano
previously approved these changes
Sep 9, 2019
There was a problem hiding this comment.
Nice! A bit unfortunate that we have to do this at all, but having played around in the past with overriding the system-level Python I remember what it's like :)
My only comment is: it would be nice to add a comment block at the top of the script explaining the purpose of the script and why, for example, we need to do all this rather than just using the built-in or yum-installed python version.
Signed-off-by: Aloys Baillet <[email protected]>
|
I created an explicit utility script called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13
The install_python.sh now also creates a
/usr/local/bin/yumscript that unsets the PYTHONPATH and PATH and LD_LIBRARY_PATH to ensure the normal python is used so yum can function normally.This makes updating the
aswf/ci-*images simple as one only need to runsudo yum install ...for additional packages.