Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Switching Logo to Inject SVG (preferred) Throws an Error #32

Open
jeremy-farrance opened this issue Oct 28, 2021 · 0 comments
Open

Switching Logo to Inject SVG (preferred) Throws an Error #32

jeremy-farrance opened this issue Oct 28, 2021 · 0 comments

Comments

@jeremy-farrance
Copy link
Member

jeremy-farrance commented Oct 28, 2021

https://github.com/Accuraty/AccuTheme/blob/main/app/Portals/_default/Skins/AccuTheme/includes/_logo.ascx

If you comment out 2. and then make 1. do its thing, you get:

Could Not Load Theme: /Portals/_default/skins/accutheme/home.ascx, 
Error: The ID 'dnnLOGO' is already used by another control.

Quick fix is to just delete the line, ID="dnnLOGO"

However, the real problem is that by being an include, ASP.NET chokes on the ID being "dnnLOGO" in both the header and footer, which is not allowed. What is a better solution?

  • I doubt we are using #dnnLOGO as a reference in the CSS?
  • Can we solve it with code? <%= ??? %>
  • Is there a way to pass in a param value for these ancient static includes?
  • Is there a more modern way to do these includes (e.g. something similar Razor's @RendorPartial or ??
  • Initial reading on the subject suggests that we should NOT be using <!--#include file="_filename.ext"--> at all
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant