Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination improvement use dict of ints and expect it everywhere #55

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

igieon
Copy link
Contributor

@igieon igieon commented Jun 11, 2021

  • default PAGE_SIZE can disable pagination only when is requested
  • tests

- default PAGE_SIZE can disable pagination only when is requested
- tests
@igieon igieon force-pushed the pagination_improvement branch from 4d35856 to 8dd83f6 Compare June 15, 2021 13:41
@coveralls
Copy link

coveralls commented Jun 15, 2021

Pull Request Test Coverage Report for Build 1191242996

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • 43 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 83.206%

Files with Coverage Reduction New Missed Lines %
flask_combo_jsonapi/querystring.py 1 93.88%
flask_combo_jsonapi/data_layers/alchemy.py 5 83.87%
flask_combo_jsonapi/resource.py 6 91.16%
flask_combo_jsonapi/api.py 31 45.97%
Totals Coverage Status
Change from base Build 939390445: 0.1%
Covered Lines: 1308
Relevant Lines: 1572

💛 - Coveralls

@mahenzon
Copy link
Collaborator

Hi! Why do you suggest disabling default pagination?

@igieon
Copy link
Contributor Author

igieon commented Aug 17, 2021

I have request from our PO that for small API we don't need pagination currently pagination can't by disabled with global settings this patch just change this so you can put as default PAGE_SIZE=0.

Copy link
Collaborator

@mahenzon mahenzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@mahenzon
Copy link
Collaborator

mahenzon commented Sep 1, 2021

hey, sorry for a delay, it's a good feature. thank you for your contribution!

@mahenzon mahenzon merged commit 824fc10 into AdCombo:master Sep 1, 2021
@igieon igieon deleted the pagination_improvement branch September 1, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants