Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages with existing package.json files try to compile non .ino deps to weird results #20

Open
soldair opened this issue Jun 14, 2014 · 2 comments

Comments

@soldair
Copy link
Contributor

soldair commented Jun 14, 2014

for example https://github.com/Pinoccio/library-bitlash/blob/master/package.json

this includes some node js deps for testing or whatever. these should be ignored.
the owner of the package should be able to override this behavior in their npm scripts for install if they want to compile deps that do not end in ".ino"

noting it here because i didn't have a chance to fix it today

@AdamMagaluk
Copy link
Owner

Figured I'd run into this sooner of later. Currently leo scans the node_modules directory and tries to compile each module as a leo package. If you have js dependencies it can screw things up.

Few alternatives I've been thinking about:

  1. Only try to build modules ending in ".ino". This seems pretty restrictive.
  2. In package.json add a property leoIgnore to ignore js dependencies.
  3. Or the other direction, manually specify leo dependencies with leoDependancies.
  4. In leo packages specify in package.json that it's leo compatible with leo: true. Only build packages that meet that requirement. Could be problematic with people forgetting.

Any others?

@soldair
Copy link
Contributor Author

soldair commented Jun 19, 2014

when i was thinking of this originally i just figured that each package would build itself via a build script triggered on npm install. this way it would be up to the package. it probably would be weird if everything depended on leo though.

ill think about it more and see if i can give better feedback. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants