Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for domain auditing #1762

Open
3 tasks done
yegle opened this issue Jun 2, 2020 · 5 comments
Open
3 tasks done

Support for domain auditing #1762

yegle opened this issue Jun 2, 2020 · 5 comments

Comments

@yegle
Copy link

yegle commented Jun 2, 2020

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

There's an audit feature in PiHole. It gives you the top permitted and blocked domains. For each of them you can mark it as "audited" indicating you are ok with it being permitted/blocked. The audited domain will no longer appear on the audit page.

This is useful to examine the full list of the domains from your network, and to identify missed ad/tracking domains from the permitted domains list.

(See also https://pi-hole.net/2017/12/06/pi-hole-v3-2-introduces-long-term-statistics-an-audit-log-colours-and-more/)

Proposed Solution

Support auditing the top permitted/blocked domains.

Alternatives Considered

Additional Information

@Aikatsui
Copy link
Contributor

Aikatsui commented Jun 2, 2020

How about #1164? and it can filter based on time or category as mentioned above blocked domains

@yegle
Copy link
Author

yegle commented Jun 2, 2020

I think they are different. The audit feature ensures I can review every permitted domain and with no duplicated effort. The linked feature looks like I can periodically review top permitted domains but I may look at the exact same list of top permitted domains everytime?

@yegle
Copy link
Author

yegle commented Jun 2, 2020

Hmm I think what I need is on top of #1164, by adding a "hide this domain" button as the rightmost column in the collapsed view, so I can slowly go over all permitted domain.

If this can be implemented it would be more powerful than PiHole's audit feature. In PiHole you can only audit the permitted list from all clients, whereas in AdGuard Home we can focused on certain clients and audit them first.

@ameshkov
Copy link
Member

ameshkov commented Jun 2, 2020

This is an interesting idea indeed, let's see how many upvotes it gets.

@Aikatsui
Copy link
Contributor

Aikatsui commented Jun 3, 2020

@yegle Hmm I think what I need is on top of #1164,
If this can be implemented it would be more powerful than PiHole's audit feature. In PiHole you can only audit the permitted list from all clients, whereas in AdGuard Home we can focused on certain clients and audit them first.

While this feature adds to query log; you can definitely get benefit from many other features than i mentioned above (time range, category blocked, malware, adult) and client range, hide domains #594 (comment), realtime features and other. you can find more on 'query log cosmetic changes'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants