Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date to each match #15

Open
andrew-nubbert opened this issue Oct 19, 2016 · 2 comments
Open

Add date to each match #15

andrew-nubbert opened this issue Oct 19, 2016 · 2 comments

Comments

@andrew-nubbert
Copy link

Include the date each game was played.
Show this in places where matches are displayed (recent results on main page and on per-player pages).

This could then be used in various ways, like "biggest upsets of the last month" or "date of highest achieved rating for each player".

@ghost
Copy link

ghost commented Oct 19, 2016

Nice idea, but is this going to involve a "database" update? what do we do about existing results?

@andrew-nubbert
Copy link
Author

Good points. This would indeed require a database update, and some way of coping with not having a date for existing results. Could well be awkward. E.g. if you use a placeholder date ("1st October 2016") for all existing matches, it'll appear in lots of the stats. If you use "Unknown" it'll require special case code to avoid trying to parse it as a date.

So yes, maintaining back-compatibility with existing results sounds like a bit of a pain, and this may not give us the best bang-for-buck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants