Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation for node names #3

Open
VermaSh opened this issue Mar 15, 2018 · 4 comments
Open

Validation for node names #3

VermaSh opened this issue Mar 15, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@VermaSh
Copy link
Contributor

VermaSh commented Mar 15, 2018

Once we have figured out a naming convention for nodes we should implement a validation function in the API. As of right now it only checks for length greater than 2, it didn't make sense to check for just 0 or 1.
@VermaSh VermaSh mentioned this issue Mar 15, 2018
Merged
@gdams
Copy link
Member

gdams commented Mar 15, 2018

So the naming convention has been agreed: build-cloudcone-ubuntu1604-x64-1

@jdekonin
Copy link
Contributor

Agreed by who? Is there a link to a previous discussion? Does this mean any machine that name build-* cannot run testing of any kind?

@gdams
Copy link
Member

gdams commented Mar 15, 2018

adoptium/infrastructure#162. The name is generated from our inventory.yml.

@jdekonin
Copy link
Contributor

As long as the tooling is written in a manner that the naming isn't enforced for all environments. For labs that might only have a small number of machines having a machine exclusively build or test isn't practical. Example Eclipse/OMR or Eclipse/OpenJ9 cis for which this plugin could also be used. Is there a category or keyword for both test and build?

@karianna karianna added the enhancement New feature or request label Mar 17, 2018
samuel-rubin added a commit to samuel-rubin/openjdk-jenkins-helper that referenced this issue Apr 16, 2019
@samuel-rubin
Adding git HTTPS support
988611a 
Change the credentials parameter the GIT_CREDENTIALS instead of SSH_CREDENTAILS
It now checks the git repo for https:// or git@ to determine if it is https or ssh

Fixed adoptium#3
Signed-off-by: Samuel Rubin <[email protected]>
samuel-rubin added a commit to samuel-rubin/openjdk-jenkins-helper that referenced this issue Apr 16, 2019
@samuel-rubin
Adding git HTTPS support
911665d 
Change the credentials parameter the GIT_CREDENTIALS instead of SSH_CREDENTAILS
It now checks the git repo for https:// or git@ to determine if it is https or ssh

Fixed adoptium#3
Signed-off-by: Samuel Rubin <[email protected]>
samuel-rubin added a commit to samuel-rubin/openjdk-jenkins-helper that referenced this issue Apr 16, 2019
@samuel-rubin
Adding git HTTPS support
2252246 
Change the credentials parameter the GIT_CREDENTIALS instead of SSH_CREDENTAILS
It now checks the git repo for https:// or git@ to determine if it is https or ssh

Fixed adoptium#3
Signed-off-by: Samuel Rubin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@karianna @VermaSh @jdekonin @gdams