Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with artist images (Last.FM API change) #149

Closed
cesfhiil opened this issue May 3, 2019 · 4 comments
Closed

Problem with artist images (Last.FM API change) #149

cesfhiil opened this issue May 3, 2019 · 4 comments
Labels

Comments

@cesfhiil
Copy link

cesfhiil commented May 3, 2019

Describe the bug
Artist images (not album images) are not generating right, and instead displays a white star image. Can reset the image, but goes back to the white star image. Also happens on other music apps that generate artist images.

To Reproduce
Steps to reproduce the behaviour:

  1. Artist images try to auto-generate, but displays white star.
  2. Go reset artist image on selected artist.
  3. Artist image resets for a while then goes back to displaying white star.

Expected behaviour
Displays the generated artist images auto-downloaded from the internet.

Screenshots
Screenshot_20190503-191835_Vinyl Music Player

Smartphone (please complete the following information):

  • Device: Samsung Galaxy S7
  • Android Version: OneUI on Android Pie
  • ROM: LightROM and BlackDiamondROM (Custom ROMs)
  • Vinyl Music Player Version: 0.21.1

Additional context
Did not have this problem on LineageOS 15.1 (just installed the custom rom today). Tried resetting Media Storage, still nothing. Tried disabling the stock music app (Samsung Music) but still doesn't work. Sorry if I got something wrong as I made this account today to start finding bugs (I got spare time, why not).

@cesfhiil cesfhiil added the bug label May 3, 2019
@GeoZac
Copy link

GeoZac commented May 4, 2019

@cesfhiil This seems to be an issue at LastFM's end. Not directly related to the player.

@cesfhiil cesfhiil changed the title Problem with artist images Problem with artist images (Last.FM API change) May 6, 2019
@cellularlupus
Copy link

Here's the announcement from the Last.fm staff about this. There's now no way to download images from Last.fm using the API. It seems they have no intention of changing it.

@cesfhiil
Copy link
Author

I wonder if we could use Discogs' API instead?

@paolovalerdi
Copy link
Contributor

Let's hope #156 gets merged

jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 1, 2023
Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 1, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 3, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)

*refactor: remove `last.fm` API axios instance

*feat(style): hero section
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 5, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)

*refactor: remove `last.fm` API axios instance

*feat(style): hero section

*refactor: rename component

*refactor: date utility

*feat(style): latest release section
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 7, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)

*refactor: remove `last.fm` API axios instance

*feat(style): hero section

*refactor: rename component

*refactor: date utility

*feat(style): latest release section

*feat(style – wip): releases section

*feat(style – wip): releases section

*feat(style – wip): releases section
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 10, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)

*refactor: remove `last.fm` API axios instance

*feat(style): hero section

*refactor: rename component

*refactor: date utility

*feat(style): latest release section

*feat(style – wip): releases section

*feat(style – wip): releases section

*feat(style – wip): releases section

*docs: add TODO

*fix: incorrectly wrapping content with `<h2>`

*feat: add proper horizontal overflow for releases lists

*refactor: make release list section titles consistent

*feat: proper vertical spacing for release sections
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 11, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)

*refactor: remove `last.fm` API axios instance

*feat(style): hero section

*refactor: rename component

*refactor: date utility

*feat(style): latest release section

*feat(style – wip): releases section

*feat(style – wip): releases section

*feat(style – wip): releases section

*docs: add TODO

*fix: incorrectly wrapping content with `<h2>`

*feat: add proper horizontal overflow for releases lists

*refactor: make release list section titles consistent

*feat: proper vertical spacing for release sections

*feat(style – wip): about the artist section
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 12, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)

*refactor: remove `last.fm` API axios instance

*feat(style): hero section

*refactor: rename component

*refactor: date utility

*feat(style): latest release section

*feat(style – wip): releases section

*feat(style – wip): releases section

*feat(style – wip): releases section

*docs: add TODO

*fix: incorrectly wrapping content with `<h2>`

*feat: add proper horizontal overflow for releases lists

*refactor: make release list section titles consistent

*feat: proper vertical spacing for release sections

*feat(style – wip): about the artist section

*feat(style): artist socials section

*feat(style): artist streaming platforms section

*feat(style): add vertical spacing to about the artist section

*refactor: use `overflow-x` instead of `overflow`

*feat(style): add horizontal padding to about the artist section

*fix: broken artist origin label spacing

*feat(style): add background line svg pattern to about the artist section
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 13, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)

*refactor: remove `last.fm` API axios instance

*feat(style): hero section

*refactor: rename component

*refactor: date utility

*feat(style): latest release section

*feat(style – wip): releases section

*feat(style – wip): releases section

*feat(style – wip): releases section

*docs: add TODO

*fix: incorrectly wrapping content with `<h2>`

*feat: add proper horizontal overflow for releases lists

*refactor: make release list section titles consistent

*feat: proper vertical spacing for release sections

*feat(style – wip): about the artist section

*feat(style): artist socials section

*feat(style): artist streaming platforms section

*feat(style): add vertical spacing to about the artist section

*refactor: use `overflow-x` instead of `overflow`

*feat(style): add horizontal padding to about the artist section

*fix: broken artist origin label spacing

*feat(style): add background line svg pattern to about the artist section

*refactor(style): refine `line-height` for artist bio

*refactor(style): artist social/stream labels `font-size`

*docs: add potential solution for broken SVGs
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 17, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)

*refactor: remove `last.fm` API axios instance

*feat(style): hero section

*refactor: rename component

*refactor: date utility

*feat(style): latest release section

*feat(style – wip): releases section

*feat(style – wip): releases section

*feat(style – wip): releases section

*docs: add TODO

*fix: incorrectly wrapping content with `<h2>`

*feat: add proper horizontal overflow for releases lists

*refactor: make release list section titles consistent

*feat: proper vertical spacing for release sections

*feat(style – wip): about the artist section

*feat(style): artist socials section

*feat(style): artist streaming platforms section

*feat(style): add vertical spacing to about the artist section

*refactor: use `overflow-x` instead of `overflow`

*feat(style): add horizontal padding to about the artist section

*fix: broken artist origin label spacing

*feat(style): add background line svg pattern to about the artist section

*refactor(style): refine `line-height` for artist bio

*refactor(style): artist social/stream labels `font-size`

*docs: add potential solution for broken SVGs

*chore(stylelint): ignore rule

*feat(style): add release hover effect

*refactor(style): add more gap space between release title and date

*feat(style): add latest release hover effect

*feat: click release to navigate to respective release page

*feat: click latest release to navigate to respective release page

*docs: add comments
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 18, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)

*refactor: remove `last.fm` API axios instance

*feat(style): hero section

*refactor: rename component

*refactor: date utility

*feat(style): latest release section

*feat(style – wip): releases section

*feat(style – wip): releases section

*feat(style – wip): releases section

*docs: add TODO

*fix: incorrectly wrapping content with `<h2>`

*feat: add proper horizontal overflow for releases lists

*refactor: make release list section titles consistent

*feat: proper vertical spacing for release sections

*feat(style – wip): about the artist section

*feat(style): artist socials section

*feat(style): artist streaming platforms section

*feat(style): add vertical spacing to about the artist section

*refactor: use `overflow-x` instead of `overflow`

*feat(style): add horizontal padding to about the artist section

*fix: broken artist origin label spacing

*feat(style): add background line svg pattern to about the artist section

*refactor(style): refine `line-height` for artist bio

*refactor(style): artist social/stream labels `font-size`

*docs: add potential solution for broken SVGs

*chore(stylelint): ignore rule

*feat(style): add release hover effect

*refactor(style): add more gap space between release title and date

*feat(style): add latest release hover effect

*feat: click release to navigate to respective release page

*feat: click latest release to navigate to respective release page

*docs: add comments

*feat: wire up album page artist back link

*docs: add TODO comment

*refactor: reuse route `path` property instead of explictly repeating route path string
jackthta added a commit to jackthta/mellifluous that referenced this issue Jul 19, 2023
NOTE: Unfortunately lost previous squashed commit history because
  I mistakenly reset the commit containing them.

*chore: `.gitignore` `.env` file

*build(npm): add `dotenv-webpack` webpack plugin for environment variable management

*build(webpack): add `dotenv-webpack` to webpack config

*feat: create `Wikipedia` API `axios` instance

*feat: add type for `Wikipedia` API biography result

*feat: fetch artist biography and display

*chore: appease TSC

*refactor: the MusicBrainz `Genre` type

*feat: add release group MusicBrainz type

*refactor: fetch `release-groups` instead of `releases` as it contains the needed release type

*refactor: extract out album cover art image into a component

*docs: add TODO comments

*feat(wip): display artist's albums

*refactor: the MusicBrainz types

*feat(wip): display album cover art

*refactor: remove comments, polish code a bit

*feat: add `AbortController` `signal` to array of AJAX requests

*feat: sort album years in descending order

*docs: add note to self on understanding how the `Array.prototype.sort` compare function works

*feat: display EPs

*feat: display Singles

*fix: create workaround for when MusicBrainz API sometimes not returning expected cover art URLs

*feat: only show release group type section if there are releases to show

*docs: add TODO comments

*feat: add sizes to `<AlbumCoverArt>`

*docs: add TODO comment

*chore(lint): organize imports

*feat: create date utility to format dates to display in "long" style

*refactor: utilize date util

*feat: display latest release

*chore: update `typescript` to nightly build to add definition for `toSorted` `Array` method

*docs: appease strange and stubborn tsc error

*docs: add foot note detailing tsc appease research

*feat: don't show latest release if it doesn't exist

*docs: add proper comment labeling of elements

*refactor: extract latest release into component

*feat: display track count for latest release

*refactor: extract release sections into re-usable component

*docs: remove unneeded comment

*refactor: enhance code readability

*refactor: artist socials into component

*refactor: artist streaming platforms into component

*refactor: artist origin into component

*refactor: use function declaration over arrow function for semantics/readability

*refactor: for better semantics/readability

*fix: some streaming platform labels not being title cased

*feat: create `last.fm` API axios instance

*refactor: make artist components default exported

*refactor: remove similar artists section

Unfortunately, last.fm decided to stop returning artist
image data...
(@see VinylMusicPlayer/VinylMusicPlayer#149)

*refactor: remove `last.fm` API axios instance

*feat(style): hero section

*refactor: rename component

*refactor: date utility

*feat(style): latest release section

*feat(style – wip): releases section

*feat(style – wip): releases section

*feat(style – wip): releases section

*docs: add TODO

*fix: incorrectly wrapping content with `<h2>`

*feat: add proper horizontal overflow for releases lists

*refactor: make release list section titles consistent

*feat: proper vertical spacing for release sections

*feat(style – wip): about the artist section

*feat(style): artist socials section

*feat(style): artist streaming platforms section

*feat(style): add vertical spacing to about the artist section

*refactor: use `overflow-x` instead of `overflow`

*feat(style): add horizontal padding to about the artist section

*fix: broken artist origin label spacing

*feat(style): add background line svg pattern to about the artist section

*refactor(style): refine `line-height` for artist bio

*refactor(style): artist social/stream labels `font-size`

*docs: add potential solution for broken SVGs

*chore(stylelint): ignore rule

*feat(style): add release hover effect

*refactor(style): add more gap space between release title and date

*feat(style): add latest release hover effect

*feat: click release to navigate to respective release page

*feat: click latest release to navigate to respective release page

*docs: add comments

*feat: wire up album page artist back link

*docs: add TODO comment

*refactor: reuse route `path` property instead of explictly repeating route path string

*feat(style): make artist origin flag proper size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants