Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 4.9 #6578

Closed
wants to merge 6 commits into from
Closed

Typescript 4.9 #6578

wants to merge 6 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Nov 16, 2022

Description

Adopts Opaque from type-fest to get around these new errors:

../governance/src/contractGovernance/governApi.js:47:22 - error TS2344: Type 'string' does not satisfy the constraint 'object'.

47   /** @type {WeakSet<Instance>} */
                        ~~~~~~~~

../governance/src/contractGovernance/governApi.js:48:9 - error TS2322: Type 'WeakSet<object>' is not assignable to type 'WeakSet<"Instance">'.

48   const voteCounters = new WeakSet();
           ~~~~~~~~~~~~

Security Considerations

New dependency, type-fest, but only a devDependency.

Documentation Considerations

Testing Considerations

CI

@turadg turadg requested a review from mhofman November 16, 2022 23:49
@turadg turadg marked this pull request as ready for review November 17, 2022 16:09
@turadg turadg marked this pull request as draft May 1, 2023 17:53
@turadg
Copy link
Member Author

turadg commented May 1, 2023

repurpose for 5.1

@turadg turadg mentioned this pull request May 22, 2023
@turadg turadg closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant