TypeScript 5.1

[turadg]

closes: #7534
supersedes: #6578

Description

Upgrade TypeScript to 5.1.6. Release notes for 5.1:
https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/

5.1.6 fixes a regression with typescript-eslint: typescript-eslint/typescript-eslint#6934

A key benefit to upgrading is getting @satisfies This doesn't yet adopt that because it will require some changes to the jsdoc linting too.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

CI

[dckc]

This bumps to the RC, not release. For our purposes that's sufficient.

I'm not clear on what our purposes are. Help?

the satisfies feature: microsoft/TypeScript#51753.

I looked at that issue briefly; it's not clear to me how it helps us.

#7534 says

We've been stuck on 4.7

I don't see a problem with 4.7.

[dckc]

I don't understand the motivation well enough to approve.

[mhofman]

Thanks for keeping up with this. Since it took me this long to come around reviewing it, let's go all the way to 5.1. Also especially with parsers, I'd prefer if we could dedup the deps and effectively bump the version instead of adding a newer version.

[mhofman]

I don't see a problem with 4.7.

In general we should keep up with newer revisions of TS. Besides bug fixes and improvements, it makes it more likely that the code editor will be using the same version in its language server (if using the default configuration to use the built-in version instead of repo specific version).