fix: adapt source task shutdown logic to work with newer versions of … #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka Connect underwent a change in its shutdown logic for source tasks around version 2.6.2 that caused
SourceTask::stopto only be invoked after any in-progress calls toSourceTask::pollhad returned; see KAFKA-15090 for more detail.As a result, when running the source connector in these newer runtimes, a resource leak may occur where database connections are never closed.
This PR changes the shutdown logic in
SourceTask::stopto:SourceTask::pollto complete (in order to handle the possibility that the connector has been deployed onto an older runtime)In addition, all resource release logic at the end of
SourceTask::pollhas been removed in favor of the logic added toSourceTask::stop.