Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fixed height for the scroll of the bib. #115

Closed
blackfalcon opened this issue Oct 7, 2022 · 5 comments
Closed

Set fixed height for the scroll of the bib. #115

blackfalcon opened this issue Oct 7, 2022 · 5 comments

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Oct 7, 2022

Is your feature request related to a problem? Please describe.

See the following issue for background on how this was discovered and the design work that was done.

There is also this issue that came in after this was created that we should also consider from a UX point of view and perhaps use the same solution for both use cases where we have a long list of options with auro-select.

Describe the solution you'd like

The design should be discussed as to how this solves the original issue that was submitted. A technical specification needs to be discussed with the team and exit criteria defined.

AC:

  • When a user interacts with the the scroll bar the bib should not close.
  • The bib can never be taller than the screen size.
  • The bib will leave a little space at the bottom of the screen so it never looks cut off.
  • The bib needs a min-height defined.
  • We need to decide if we want to support specific sizes or whether the user can make it any size they want with css.

Note for `finement.

The flight search team implemented the work around Geoff suggested for the currency converter.
https://www.alaskaair.com/search/results?A=1&O=sea&D=las&OD=2023-08-25&OT=Anytime&DD=2023-08-25&DT=Anytime&UPG=none

Scroll down to the bottom of the page and click on the currency converter in the fine print.

@blackfalcon
Copy link
Member Author

Meeting is scheduled with the team for a feature tech'refinement discussion.

@jason-capsule42
Copy link
Member

When a user interacts with the the scroll bar the bib should not close.

This should be removed from the AC. It is already implemented.

@jason-capsule42
Copy link
Member

The bib will leave a little space at the bottom of the screen so it never looks cut off.

This should at a minimum include the top as well.

We may want to look at left and right padding as well. This portion of the change may need to be in auro-dropdown though. Since we would want consistent behavior between at minimum auro-select and auro-combobox.

@blackfalcon
Copy link
Member Author

Post conversation it was agreed that this work is not priority and the thing to be done is to update the demo to illustrate how a user can simply use CSS to restrict height and auro-menu will naturally listen to this.

@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Nov 15, 2022
@blackfalcon blackfalcon added the not-reviewed Issue has not been reviewed by Auro team members label Jan 21, 2023
@jason-capsule42 jason-capsule42 removed not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Oct 3, 2024
@jordanjones243
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants