-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: rename_all for enums doesn't match serde #236
Comments
Hey @stegaBOB, thanks for the report! Can you provide an example of the bug? If it can't be reproduced after #198, this may be a duplicate of #194 |
Ah! Looking at that fix, it looks like that would do the trick. I should have tried the latest git changes first. Would it be possible to cut a new release? |
Gotcha |
#184 fixed the issue for struct fields, but enum variants don't have underscores so they will end up all lowercase with camel and pascal case. Serde's implementation has separate logic for enums and structs, so doing the same thing here would probably fix it.
https://github.com/serde-rs/serde/blob/1d54973b928bd8708a4ad2d90fca1203367ff580/serde_derive/src/internals/case.rs#L57
The text was updated successfully, but these errors were encountered: