Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use this with SSH remote #7

Closed
GitMensch opened this issue Mar 2, 2024 · 15 comments
Closed

How to use this with SSH remote #7

GitMensch opened this issue Mar 2, 2024 · 15 comments

Comments

@GitMensch
Copy link

Or: Do you plan to add REH binaries?

@Alex313031
Copy link
Owner

@GitMensch Actually, everytime I build, it makes reh archives. I didn't think anyone wanted or used it, because isn't that just the web version of VSCode? Because in that case there's really no point, and Codium doesn't offer any benefit over upstream. Codium is for people who want compiler optimization, to use it on old OSes i.e. windows 7, or because they dislike the vscodium logo.

@GitMensch
Copy link
Author

GitMensch commented Mar 6, 2024 via email

@Alex313031
Copy link
Owner

@GitMensch OOOO ok. I will release the reh archives alongside them from now on. Thnx. Sorry I didn't before, I could have the whole time because it builds it as part of the whole compilation process, I just didn't think it was necessary. I never use the web version, ssh, or the tunnel introduced recently, so I didn't know anything about it.

@Alex313031
Copy link
Owner

@GitMensch Latest 1.87.2 version has REH for Linux and Windows > https://github.com/Alex313031/codium/releases/tag/1.87.2.24075

@GitMensch
Copy link
Author

Than you. The codium_reh works on my boxes; to have that automatically installed by Open SSH Remote one can configure (=override) its setting remote.SSH.serverDownloadUrlTemplate
https://github.com/jeanp413/open-remote-ssh/blob/8191939de706952fa035f80a6fce0e85f85495f6/package.json#L81

But the installation would have to be done manually for now, as its install script expects it to have in gzip'd tar format, not as zip file https://github.com/jeanp413/open-remote-ssh/blob/8191939de706952fa035f80a6fce0e85f85495f6/src/serverSetup.ts#L318-L343

To ease that and allow automatic installation - can you please adjust the reh binaries to be made available as tar.gz?

@GitMensch
Copy link
Author

Jut out of interest: your binaries include node 16.17.1; is there a plan to increase that or is that version necesary to support older environments?

@Alex313031
Copy link
Owner

Alex313031 commented Mar 16, 2024

@GitMensch Yeah, next release I can leave them as .tar.gz

And well, as you know this fork is using Node 16 and Electron 22 for old OS support, i.e. Windows 7/8/8.1 & Ubuntu 18.04/Debian 9. But actually, VSCodium is also using Node16 (only for the REH archives), see > https://github.com/VSCodium/vscodium/blob/master/patches/linux/reh-node16.patch

@Alex313031
Copy link
Owner

@GitMensch How are the reh archives working for you now? I am making Linux and Windows ones, using Node 16 (same node as the Electron 22.3.27 that this fork is using)

@GitMensch
Copy link
Author

GitMensch commented May 12, 2024 via email

@vcip
Copy link

vcip commented Oct 24, 2024

hi alex313031, codium 1.93.1.24277 can't use ssh remote, because it download server from "default": "https://github.com/VSCodium/vscodium/releases/download/${version}.${release}/vscodium-reh-${os}-${arch}-${version}.${release}.tar.gz", but Vscodeim have https://github.com/VSCodium/vscodium/releases/download/1.93.1.24256/vscodium-reh-linux-x64-1.93.1.24256.tar.gz only, not 1.93.1.24277.tar.gz, so can't use ssh remote. can you fixed it? thanks

@Alex313031
Copy link
Owner

@vcip If you noticed, I started offering reh archives for all platforms. You can just download from my releases instead of upstream.

@vcip
Copy link

vcip commented Oct 26, 2024

@Alex313031 I have see your release build, but open ssh remote download file from VSCodium, how to let ssh remote download file from your release? modify the ssh remote code or config?

@GitMensch
Copy link
Author

remote.SSH.experimental.serverBinaryName can be used to override the hash, if there's no matching REH binary.
remote.SSH.serverDownloadUrlTemplate allowsyou to swap the default VSCodium, for example to Alex' build (as they likely have a different sha you'd either have to also use that fork instead of VSCodium or again, adjust the binary server name config)

@vcip
Copy link

vcip commented Oct 27, 2024

@Alex313031 I see, I try it, thanks very much!

@Alex313031
Copy link
Owner

Alex313031 commented Oct 27, 2024

@GitMensch @vcip Turns out this is an error on my part. I don't publish the hashes for all the files, which it fetches to compare against the downloaded reh archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants