Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateMyDatasetId helper to useDatasetManager #394

Open
nozomione opened this issue Oct 18, 2024 · 0 comments
Open

Add updateMyDatasetId helper to useDatasetManager #394

nozomione opened this issue Oct 18, 2024 · 0 comments
Assignees

Comments

@nozomione
Copy link
Member

nozomione commented Oct 18, 2024

Context

Epic: #391

Feature branch: feature/epic-refacter-use-dataset-manager-hook

In #393, we introduced a wrapper helper method updateMyDataset for the context state's setter setMyDataset.

We also have the context state myDatasetId and its setter setMyDatasetId which store and update the user-saved My Dataset ID.

To align with this new pattern, we want to create a wrapper helper method responsible for setting myDatasetId, which will also be called from the hook methods (e.g., createDataset) on API requests.

Problem or idea

We should replace all setMyDatasetId calls within the hook with the new wrapper method described above.

Solution or next step

  1. Add a new method updateMyDatasetId that accepts the dataset ID fetched from the API
  2. Replace the setMyDatasetId calls with this newly added wrapper method
@nozomione nozomione self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant