Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for altExps with different features #248

Open
sjspielman opened this issue Dec 18, 2023 · 1 comment
Open

Allow for altExps with different features #248

sjspielman opened this issue Dec 18, 2023 · 1 comment

Comments

@sjspielman
Copy link
Member

As part of #150, we are enforcing that altExps of the same name (e.g., "adt") all have the same features during merging. In the future, we would like to allow for feature mismatch to merge altExps in cases where not all features will necessarily present in all altExps of that given name.

@sjspielman
Copy link
Member Author

sjspielman commented Dec 21, 2023

Something else to think about when the time comes, from #253 (comment):

I kept failures for different features, as I think that we may want to discuss what to do in the case of altExps with the same names but different feature sets: do we combine those or turn them into separately named altExps? I don't know yet, so failure seems the best option.

Edit: Noting there has been another vote for this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant