Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix injection gap math #1859

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix injection gap math #1859

merged 2 commits into from
Dec 20, 2024

Conversation

mpuccio
Copy link
Contributor

@mpuccio mpuccio commented Dec 19, 2024

The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events.

@njacazio @ddobrigk

The change introduced in AliceO2Group#1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events.
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@ddobrigk
Copy link
Collaborator

Thanks, nice catch!

@sawenzel
Copy link
Contributor

You may also take a look at the novel hybrid event generator (see for instance https://github.com/AliceO2Group/AliceO2/blob/dev/run/SimExamples/Hybrid/hybridconfig.json) which allows to pick events from multiple different generator instances in certain sequences.

@sawenzel sawenzel merged commit c23cfd2 into AliceO2Group:master Dec 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants