Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/Configure language service for C# service implementation #719

Closed
2 tasks
TheTechArch opened this issue Jan 3, 2019 · 3 comments
Closed
2 tasks
Labels
kind/analysis Used when an issue needs to be analysed before it becomes a user story. solution/studio/designer Issues related to the Altinn Studio Designer solution.

Comments

@TheTechArch
Copy link
Member

TheTechArch commented Jan 3, 2019

Functional architect/designer: @-mention
Technical architect: @TheTechArch @nkylstad

Description
We need to create (or configure) a language server for C# that can be used by the Monaco Editor in Altinn Studio. Monaco will use Monaco Language Client to call this server. This is done in #317

  • We currently does not belive there exist any installed server online we can reuse.
  • We currently does not belive there exist any existing server we can install as part of Altinn Studio without modification.

There exist open source project for the Language Service Protocool and for a Roslyn language server.

The most relevant project is Omnisharp Roslyn. According to this thread and this pull request it should now support LSP. (at least limited)

I have asked questions to see if the team can give feedback if this product is feasable or not.

Technical considerations
The server need to have access to local repo in the cloud.

Acceptance criterea

  • The language server needs to support code completion
  • It needs to follow the LSP standard for the implemented functionality
  • It needs to have access to the files in the local repostory (Azure storage)
  • It needs to support request comming for different C# projects at the same time.

Tasks

  • Analyze if we can use omnisharp-roslyn directly
  • If not, Analyze if it is possible to modify this project to support our requirements
@TheTechArch TheTechArch added logic & rules solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/analysis Used when an issue needs to be analysed before it becomes a user story. labels Jan 3, 2019
@TheTechArch TheTechArch changed the title Create/Configure langauge service for C# service implementation Create/Configure language service for C# service implementation Jan 3, 2019
@lvbachmann lvbachmann added this to the MVP milestone Feb 20, 2019
@lvbachmann
Copy link
Contributor

Note to self: Re-evaluate this once we know how likely it is that pilot service developers will write C# code in Monaco

@GGunnar
Copy link

GGunnar commented Mar 12, 2019

@helenekri @sarahwoodhouse please check with the pilots regarding writing C# in Altinn Studio.

@IneF IneF modified the milestones: MVP, Post-MVP May 7, 2019
@GGunnar GGunnar modified the milestones: Post-MVP, CD - phase 3 Oct 7, 2019
@lvbachmann lvbachmann removed this from the 2022 and beyond milestone Nov 25, 2021
@TheTechArch
Copy link
Member Author

Closing this. I dont belive this is relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/analysis Used when an issue needs to be analysed before it becomes a user story. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

No branches or pull requests

4 participants