fix: service worker cache collision on same domain #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 88.65% 87.88% -0.77%
==========================================
Files 55 55
Lines 1445 1445
Branches 225 225
==========================================
- Hits 1281 1270 -11
- Misses 126 137 +11
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@fbasso Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, if the AgnosUI demo is deployed on the same domain as another application that uses the CacheStorage (such as another instance of the AgnosUI demo), the service worker of AgnosUI will delete all other caches than its own latest version when it is activated (which happens each time the browser notices there is a new version of AgnosUI deployed).
With this PR, such deletion of caches will only happen for caches containing in their name the current service worker scope, which means only caches created from a previous version of the same service worker will be deleted.